karma: remove unnecessary image mapping#1532
Conversation
| '/v1/config/public/hero-image': '/base/apps/central/src/assets/images/whats-new/banner@1x.png', | ||
| '/v1/config/public/logo': '/base/apps/central/src/assets/images/odk-logo.png', | ||
| '/img/banner@1x.6c9e9f21.png': '/base/apps/central/src/assets/images/whats-new/banner@1x.png', // Smaller resolution for circleCI test | ||
| '/img/map-location.b523ce2d.svg': '/base/apps/central/src/assets/images/geojson-map/map-location.svg', |
There was a problem hiding this comment.
Ah I bet Vite is inlining this SVG file, so it's no longer being requested and Karma no longer needs to serve it. I'm not sure though why map-location.svg would be inlined while fullscreen.svg isn't, given that fullscreen.svg is smaller. Maybe it's because of how map-location.svg is used (in src/util/map-styles.js). Not a question we need to answer, it's just interesting. In any case, things are definitely clearer with fewer images here, LGTM. 👍 Thank you, @alxndrsn!
|
2 participants
Ref https://github.com/getodk/central-frontend/pull/1531/changes#r3063568260
What has been done to verify that this works as intended?
Tests still pass without it.
Why is this the best possible solution? Were any other approaches considered?
Less code, less to think about.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No effect - just test code.
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes